Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pmbanugo and snneji from docs-reviewers group #1578

Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented Jun 7, 2024

Changes

  • As discussed in SC meeting, we're asking people to remove themselves from the roles, if they had no activity for a year
  • Inactivity in this context means:
    • No issue creation, PR creation, commit or PR review (I didn't check issue comments) in the last 12 months.

Thanks @snneji and @pmbanugo for all the contributions!

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Jun 7, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • As discussed in SC meeting, we're asking people to remove themselves from the roles, if they had no activity for a year
  • Inactivity in this context means:
  • No issue creation, PR creation, commit or PR review (I didn't check issue comments) in the last 12 months.

Thanks @snneji and @pmbanugo for all the contributions!

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and psschwei June 7, 2024 10:36
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2024
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@knative-prow knative-prow bot merged commit da1d4f5 into knative:main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants