Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Steering and TO Committees #1587

Merged
merged 10 commits into from
Sep 17, 2024

Conversation

evankanderson
Copy link
Member

Changes

  • Unify the Steering Committee and TOC.
  • Adjust the future membership to consist of 4 elected seats, 1 end-user seat, and up to 2 selected seats to balance the set of skills on the committee.

This is based on #1549 (comment), but I've adjusted the Steering-appointed ("selected") seats to be optional and 1-year terms rather than 2-year terms with staggered appointment. I don't feel strongly about this, but it seemed to provide more flexibility.

Relates to #1549

…establishing process for future 1-election-per-year schedule.
Copy link

knative-prow bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from nainaz and salaboy July 1, 2024 01:36
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2024
STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
@psschwei
Copy link
Contributor

+1 non-binding (not on steering [yet... :) ])

STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
special elections held. In the event of a question of company membership (for
No more than two contributing seats may be held by employees of the same organization
(or conglomerate, in the case of companies owning each other). Additionally, each end
user seat (when available) must belong to an employee from a different
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the end user seat optional or mandatory? Maybe we should skip "(when available)" or otherwise mention that an end user seat is optional (which then also would decrease the size of the SC)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thanks!

Comment on lines 251 to 252
Steering Committee seats through any combination of contributing, end-user, and
selected seats. If the results of an election result in greater than two employees of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Steering Committee seats through any combination of contributing, end-user, and
selected seats. If the results of an election result in greater than two employees of
Steering Committee seats. If the results of an election result in greater than two employees of

I would just leave out the "any combination of contributing, end-user, and selected seats" as I think this is redundant and a bit confusing (what is a combination of seats, anyway?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just making clear that the sum total of seats can't be a majority. This means that the following would be disallowed:

2 $Foo elected seats
1 $Foo end-user seat
2 Non-$Foo elected seats
1 Selected seat (non-$Foo)

If $Foo is an end-user company. Another combination that would be disallowed:

2 $Foo elected seats
2 Non-$Foo elected seats
1 Non-$Foo end-user seat
1 $Foo selected seat

(Because that would give $Foo a total of 50% of the committee representation)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, we actually prevent the first scenario. But, to your point, we should move most of the company representation limits to a section that's not under "Election Procedure"

@@ -280,7 +307,9 @@ election. Any replacement SC member will serve out the remainder of the term for
the person they are replacing, regardless of the length of that remainder.

In the event of a resignation or other loss of an appointed end user KSC member,
the SC will appoint a new person to fill the end user SC seat.
the SC will appoint a new person to fill the end user SC seat. In the event of
a resignation or other loss of an appointed select KSC member, the SC may choose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "KSC" mean (compared to "SC") ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, we seem to have mixed the two abbreviations. Standardized on "KSC"

Comment on lines 150 to 153
- Four (4) are elected Contributing Seats, open to any project contributor.
Contributing Seats are elected every year, and serve a two-year term. In the
event of a vacancy, the Steering Committee may select a replacement to serve
out the remainder of the term.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Four (4) are elected Contributing Seats, open to any project contributor.
Contributing Seats are elected every year, and serve a two-year term. In the
event of a vacancy, the Steering Committee may select a replacement to serve
out the remainder of the term.
- Four (4) are elected Contributing Seats, open to any project contributor.
Contributing Seats serve a two-year term and are elected when their terms end. In the
event of a vacancy, the Steering Committee may select a replacement to serve
out the remainder of the term.

Every year and 2 years seemed contradicting to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean that e.g. 2 seats are elected this year, and 2 are elected next year, we should clarify that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified, thanks!

The Steering Committee has five (5) seats. Of these five seats, four (4) are elected
Contributing seats, open to any project contributor, and one (1) is an
[End User Seat](#end-user-seat) appointed by the Steering Committee.
The Steering Committee has five (7) seats. These 7 seats are composed as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Steering Committee has five (7) seats. These 7 seats are composed as follows:
The Steering Committee has a minimum of 5 (five) and maximum of (7) seats. These 7 seats are composed as follows:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since selected seats are optional, I've made a suggestion to update the text here. We also need to note that these are optional.

Maybe me writing optional is bad here. We should encourage SC to fill in those seats.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think those seats are optional. If we ended up with 5 people who can regularly attend and move things forward, I don't want to make them feel like they need to get 2 more warm bodies to be performing well.

@@ -280,7 +307,9 @@ election. Any replacement SC member will serve out the remainder of the term for
the person they are replacing, regardless of the length of that remainder.

In the event of a resignation or other loss of an appointed end user KSC member,
the SC will appoint a new person to fill the end user SC seat.
the SC will appoint a new person to fill the end user SC seat. In the event of
a resignation or other loss of an appointed select KSC member, the SC may choose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a resignation or other loss of an appointed select KSC member, the SC may choose
a resignation or other loss of an appointed select SC member, the SC may choose

Roland, I suppose they're the same thing :)

Comment on lines +366 to 384
To recognize the folks that have served in the TOC in the past, below we list the previous members of the TOC (sorted by their 'Term End').

|   | Member | Profile | Term Start | Term End |
| -------------------------------------------------------------- | --------------- | --------------------------------------------------- | ---------- | ---------- |
| <img width="30px" src="https://github.com/vaikas.png"> | Ville Aikas | [@vaikas](https://github.com/vaikas) | Bootstrap | 2020 |
| <img width="30px" src="https://github.com/tcnghia.png"> | Nghia Tran | [@tcnghia](https://github.com/tcnghia) | 2020 | 2021 |
| <img width="30px" src="https://github.com/mattmoor.png"> | Matt Moore | [@mattmoor](https://github.com/mattmoor) | Bootstrap | 2021 |
| <img width="30px" src="https://github.com/grantr.png"> | Grant Rodgers | [@grantr](https://github.com/grantr) | 2020 | 2021 |
| <img width="30px" src="https://github.com/markusthoemmes.png"> | Markus Thömmes | [@markusthoemmes](https://github.com/markusthoemmes) | 2020-06-09 | 2021-12-16 |
| <img width="30px" src="https://github.com/julz.png"> | Julian Friedman | [@julz](https://github.com/julz) | 2021-05-26 | 2022-02-07 |
| <img width="30px" src="https://github.com/rhuss.png"> | Roland Huß | [@rhuss](https://github.com/rhuss) | 2021-02-16 | 2022 |
| <img width="30px" src="https://github.com/mattmoor.png"> | Matt Moore | [@mattmoor](https://github.com/mattmoor) | 2022-02-07 | 2022 |
| <img width="30px" src="https://github.com/n3wscott.png"> | Scott Nichols | [@n3wscott](https://github.com/n3wscott) | 2022-01-11 | 2022-09-27 |
| <img width="30px" src="https://github.com/evankanderson.png"> | Evan Anderson | [@evankanderson](https://github.com/evankanderson) | Bootstrap | 2023-06-01 |
| <img width="30px" src="https://github.com/zroubalik.png"> | Zbynek Roubalik | [@zroubalik](https://github.com/zroubalik) | 2022-06-01 | 2023-07-31 |
| <img width="30px" src="https://github.com/krsna-m.png"> | Krsna Mahapatra | [@krsna-m](https://github.com/krsna-m) | 2023-06-01 | 2024 |


---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To recognize the folks that have served in the TOC in the past, below we list the previous members of the TOC (sorted by their 'Term End').
| &nbsp; | Member | Profile | Term Start | Term End |
| -------------------------------------------------------------- | --------------- | --------------------------------------------------- | ---------- | ---------- |
| <img width="30px" src="https://github.com/vaikas.png"> | Ville Aikas | [@vaikas](https://github.com/vaikas) | Bootstrap | 2020 |
| <img width="30px" src="https://github.com/tcnghia.png"> | Nghia Tran | [@tcnghia](https://github.com/tcnghia) | 2020 | 2021 |
| <img width="30px" src="https://github.com/mattmoor.png"> | Matt Moore | [@mattmoor](https://github.com/mattmoor) | Bootstrap | 2021 |
| <img width="30px" src="https://github.com/grantr.png"> | Grant Rodgers | [@grantr](https://github.com/grantr) | 2020 | 2021 |
| <img width="30px" src="https://github.com/markusthoemmes.png"> | Markus Thömmes | [@markusthoemmes](https://github.com/markusthoemmes) | 2020-06-09 | 2021-12-16 |
| <img width="30px" src="https://github.com/julz.png"> | Julian Friedman | [@julz](https://github.com/julz) | 2021-05-26 | 2022-02-07 |
| <img width="30px" src="https://github.com/rhuss.png"> | Roland Huß | [@rhuss](https://github.com/rhuss) | 2021-02-16 | 2022 |
| <img width="30px" src="https://github.com/mattmoor.png"> | Matt Moore | [@mattmoor](https://github.com/mattmoor) | 2022-02-07 | 2022 |
| <img width="30px" src="https://github.com/n3wscott.png"> | Scott Nichols | [@n3wscott](https://github.com/n3wscott) | 2022-01-11 | 2022-09-27 |
| <img width="30px" src="https://github.com/evankanderson.png"> | Evan Anderson | [@evankanderson](https://github.com/evankanderson) | Bootstrap | 2023-06-01 |
| <img width="30px" src="https://github.com/zroubalik.png"> | Zbynek Roubalik | [@zroubalik](https://github.com/zroubalik) | 2022-06-01 | 2023-07-31 |
| <img width="30px" src="https://github.com/krsna-m.png"> | Krsna Mahapatra | [@krsna-m](https://github.com/krsna-m) | 2023-06-01 | 2024 |
---
To recognize the folks that have served in the TOC* in the past, below we list the previous members of the TOC (sorted by their 'Term End').
| &nbsp; | Member | Profile | Term Start | Term End |
| -------------------------------------------------------------- | --------------- | --------------------------------------------------- | ---------- | ---------- |
| <img width="30px" src="https://github.com/vaikas.png"> | Ville Aikas | [@vaikas](https://github.com/vaikas) | Bootstrap | 2020 |
| <img width="30px" src="https://github.com/tcnghia.png"> | Nghia Tran | [@tcnghia](https://github.com/tcnghia) | 2020 | 2021 |
| <img width="30px" src="https://github.com/mattmoor.png"> | Matt Moore | [@mattmoor](https://github.com/mattmoor) | Bootstrap | 2021 |
| <img width="30px" src="https://github.com/grantr.png"> | Grant Rodgers | [@grantr](https://github.com/grantr) | 2020 | 2021 |
| <img width="30px" src="https://github.com/markusthoemmes.png"> | Markus Thömmes | [@markusthoemmes](https://github.com/markusthoemmes) | 2020-06-09 | 2021-12-16 |
| <img width="30px" src="https://github.com/julz.png"> | Julian Friedman | [@julz](https://github.com/julz) | 2021-05-26 | 2022-02-07 |
| <img width="30px" src="https://github.com/rhuss.png"> | Roland Huß | [@rhuss](https://github.com/rhuss) | 2021-02-16 | 2022 |
| <img width="30px" src="https://github.com/mattmoor.png"> | Matt Moore | [@mattmoor](https://github.com/mattmoor) | 2022-02-07 | 2022 |
| <img width="30px" src="https://github.com/n3wscott.png"> | Scott Nichols | [@n3wscott](https://github.com/n3wscott) | 2022-01-11 | 2022-09-27 |
| <img width="30px" src="https://github.com/evankanderson.png"> | Evan Anderson | [@evankanderson](https://github.com/evankanderson) | Bootstrap | 2023-06-01 |
| <img width="30px" src="https://github.com/zroubalik.png"> | Zbynek Roubalik | [@zroubalik](https://github.com/zroubalik) | 2022-06-01 | 2023-07-31 |
| <img width="30px" src="https://github.com/krsna-m.png"> | Krsna Mahapatra | [@krsna-m](https://github.com/krsna-m) | 2023-06-01 | 2024 |
---
> * _Technical Oversight Committee (TOC)_ was a separate committee responsible for setting the overall technical direction and roadmap of the project before 2024. In 2024, SC and TOC [was merged](https://github.com/knative/community/issues/1549) into a single governance body.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to be in-line; footnotes don't work well in markdown / web documents for the most part.

@aliok
Copy link
Member

aliok commented Jul 23, 2024

Thanks for the PR @evankanderson !

+1 from me overall, just had some questions and comments.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2024
@evankanderson
Copy link
Member Author

I got around to updating this. I'd appreciate votes from both Steering and TOC on this, as it's effectively collapsing the two efforts into one.

@aliok
Copy link
Member

aliok commented Sep 2, 2024

+1

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had one question about the temporary KSC and the company limits and a couple of minor nits

STEERING-COMMITTEE.md Show resolved Hide resolved
STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep the file for a while as a placeholder with a brief "merged to KSC" message and link to KSC charter.

@dsimansk
Copy link
Contributor

dsimansk commented Sep 5, 2024

+1

STEERING-COMMITTEE.md Outdated Show resolved Hide resolved
@nrrso
Copy link
Contributor

nrrso commented Sep 10, 2024

+1

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aliok
Copy link
Member

aliok commented Sep 11, 2024

+1

3 similar comments
@davidhadas
Copy link
Contributor

+1

@salaboy
Copy link
Member

salaboy commented Sep 16, 2024

+1

@dprotaso
Copy link
Member

+1

@evankanderson
Copy link
Member Author

I see (required) +1 votes from:

@salaboy @aliok @nrrso @evankanderson (implicit)

I see (advisory) +1 votes from:

@dprotaso @davidhadas @psschwei @dsimansk

I believe this is a sufficient majority to proceed, so I will need an /lgtm from one of the above.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🥳

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2024
@knative-prow knative-prow bot merged commit 0934efd into knative:main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.