feat(RELEASE-1158): introduce reduce-snapshot #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoheb
force-pushed
the
RELEASE-1158
branch
2 times, most recently
from
55fab62
to
066d49a
Compare
johnbieren
reviewed
Sep 12, 2024
scoheb
force-pushed
the
RELEASE-1158
branch
4 times, most recently
from
c43c0b9
to
63f613f
Compare
mmalina
reviewed
Sep 12, 2024
mmalina
reviewed
Sep 12, 2024
scoheb
force-pushed
the
RELEASE-1158
branch
2 times, most recently
from
d78a246
to
54d4c62
Compare
johnbieren
reviewed
Sep 12, 2024
scoheb
force-pushed
the
RELEASE-1158
branch
2 times, most recently
from
39394fe
to
e33473f
Compare
johnbieren
reviewed
Sep 12, 2024
johnbieren
reviewed
Sep 12, 2024
scoheb
force-pushed
the
RELEASE-1158
branch
8 times, most recently
from
34ec53b
to
0c2f22e
Compare
scoheb
force-pushed
the
RELEASE-1158
branch
4 times, most recently
from
f460a98
to
3dc5e99
Compare
johnbieren
reviewed
Sep 19, 2024
There was a problem hiding this comment.
The reduce-snapshot tests are a little confusing to me because every one applies a snapshot and creates a snapshot.json file. However, some tests do not use the CR, and some do not use the json. Can the setup part of the tests only create the json or the CR (whatever is used) and not the other?
tasks/reduce-snapshot/tests/test-reduce-snapshot-disabled-single-component-mode.yaml
Outdated
Show resolved
Hide resolved
tasks/reduce-snapshot/tests/test-reduce-snapshot-missing-resource.yaml
Outdated
Show resolved
Hide resolved
tasks/reduce-snapshot/tests/test-reduce-snapshot-no-namespace-parameter.yaml
Outdated
Show resolved
Hide resolved
tasks/reduce-snapshot/tests/test-reduce-snapshot-wrong-component.yaml
Outdated
Show resolved
Hide resolved
scoheb
force-pushed
the
RELEASE-1158
branch
from
3dc5e99
to
0bc57bc
Compare
johnbieren
approved these changes
Sep 20, 2024
- This PR contains a new Task called reduce-snapshot - It is designed to reduce a Snapshot to a Single Component such that the Snapshot can be passed downstream to other tasks. - It uses a shared script from Enterprise Contract so that the ITS EC pipeline uses the same logic to reduce the snapshot. - A new step was added to the collect-data task, to provide data needed for the parameters of the reduce-snapshot task. - A new RPA data parameter called `singleComponentMode` is used to activate the feature. Signed-off-by: Scott Hebert <[email protected]>
scoheb
force-pushed
the
RELEASE-1158
branch
from
0bc57bc
to
2bb5248
Compare
|
New changes are detected. LGTM label has been removed. |
|
/test release-pipelines-e2e-suite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce-snapshotsuch that the Snapshot can be passed downstream to other tasks.
ITS EC pipelineuses the same logic to reduce the snapshot.collect-datatask, to providedata needed for the parameters of the
reduce-snapshottask.singleComponentModeis used toactivate the feature.