Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix (or make unnecessary) brendanzab/gl-rs#528, which was an attempt to fix
webgl_stdweb
compiling underwasm-pack
/wasm-bindgen
. It was giving me these kind of errors:I was able to patch it by just adding
wasm-bindgen
as a dep towebgl_stdweb
, but I realized I was also able to fix it directly in stdweb by importingwasm_bindgen
inside thejs!()
/derive(ReferenceType)
macros. I think it was failing becausewasm-bindgen
's macros expect to be able to accesswasm_bindgen
, but because crates invoking thestdweb
macros that invoke thewasm-bindgen
macros don't necessarily havewasm_bindgen
in scope, it might fail to compile.