Added ability to wrap mocks under define #1145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
@pavel-trafimuk mind adding info to the template docs? |
EnesKaraosman
approved these changes
Apr 5, 2024
|
Please let me few days to update this MR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mocks don't have ability to be hidden for some purposes, e.g. release/production.
Yes, we can generate them only in unit-test targets, but this approach does not work in multi-modules real app:
when I want mocks from moduleA in tests of moduleB and moduleC.
So it's better to put generated mocks in moduleA, but wrap them under define, so they will not expose in release code.
To do that, I add new optional argument
mockWrapDefine