fix hcloud-csi.yaml if csi is disabled (disable_hetzner_csi) #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I came across the same issue |
Yes, that's the other way to solve it. |
mysticaltech
requested changes
Sep 22, 2024
mysticaltech
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1470 which was introduced with #1417.
disable_hetzner_csi = falsethencsi_versionwill always be set (either fromhetzner_csi_versionor using the latest github release).disable_hetzner_csi = truethencsi_versionwill not be automatically be inferred from the latest github release. This is why rendering thetemplatefilefails, even though the file is not needed and ignored. This PR fixes rendering the template usingcoalesce. This way the file will be generated but is still not used since csi is disabled.