Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k3s-token and k3s-endpoint as output so other modules can re-use it. #946

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

nupplaphil
Copy link
Contributor

@nupplaphil nupplaphil commented Aug 27, 2023

Hi there,

I'm currently building a terraform environment to add root-server to this cluster.
This is my current state of work: https://github.com/nupplaphil/terraform-root-kube-hetzner

Since I don't want to mix up root server and hcloud server, I choose a different repo for it.

The only thing missing is the "glue" between the hcloud terraform module and my root terraform module.
--> the k3s token and endpoint is missing.

With these two outputs, I was successfully to add a root-server to a cluster out of this project :)

btw the cilium config

loadBalancer:
  # Enable LoadBalancer & NodePort XDP Acceleration (direct routing (routingMode=native) is recommended to achieve optimal performance)
  acceleration: native

doesn't work because XDP is incompatible with the vlan interface of the vSwitch subnet.
--> I manually overwrite the cilium_values

@nupplaphil nupplaphil added the enhancement New feature or request label Aug 27, 2023
Copy link
Collaborator

@mysticaltech mysticaltech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, super interesting!

@mysticaltech
Copy link
Collaborator

@nupplaphil If you could add an example on how to use metal in the examples folder, it would be great. Including your custom cilium values. As a lot of people want to use this.

@mysticaltech
Copy link
Collaborator

@schlichtanders Doesn't that answer the need of #953 and #949?

@mysticaltech mysticaltech changed the base branch from master to staging August 31, 2023 09:43
@mysticaltech mysticaltech merged commit 5403f33 into kube-hetzner:staging Aug 31, 2023
1 check passed
@nupplaphil nupplaphil deleted the enh/output branch September 24, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants