Skip to content

Commit

Permalink
Make basic-health image configurable (#3622)
Browse files Browse the repository at this point in the history
* Make basic-health image configurable

in order to be able to pull all images from a private registry, we need to have the basic-health image configurable

* comment out basicHealth.fullImageName in values.yaml and use default in template instead

---------

Co-authored-by: Jesse Goodier <[email protected]>
Co-authored-by: Chip Zoller <[email protected]>
Co-authored-by: Thomas Nguyen <[email protected]>
  • Loading branch information
4 people authored Sep 27, 2024
1 parent 89a1132 commit 7af7e61
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cost-analyzer/templates/tests/basic-health.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ spec:
fsGroup: 2000
containers:
- name: test-kubecost
image: alpine/k8s:1.26.9
image: {{ (.Values.basicHealth).fullImageName | default "alpine/k8s:1.26.9" }}
securityContext:
privileged: false
capabilities:
drop:
drop:
- ALL
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
Expand All @@ -42,7 +42,7 @@ spec:
if [ "$code" -eq 200 ]; then
echo "Got Kubecost working configuration. Successful."
exit 0
else
else
echo "Failed to fetch Kubecost configuration. Response was $response"
exit 1
fi
4 changes: 4 additions & 0 deletions cost-analyzer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3558,3 +3558,7 @@ extraObjects: []
# host: kubecost.kubecost.svc.cluster.local
# port:
# number: 80

# -- Optional override for the image used for the basic health test container
# basicHealth:
# fullImageName: alpine/k8s:1.26.9

0 comments on commit 7af7e61

Please sign in to comment.