Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containerStatsEnabled from values files #3683

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

thomasvn
Copy link
Member

@thomasvn thomasvn commented Sep 23, 2024

What does this PR change?

ContainerStats ETL files are not currently used by the product. Disable this feature on all agents to reduce the load incurred on Cost-model and Prometheus containers.

Does this PR rely on any other PRs?

Yes. An associated Frontend PR will be required to remove the following warning banner. The QuantileOfMax and QuantileOfAverages algorithms should be available for use out of the box with no additional configuration.

Screenshot 2024-09-23 at 11 35 47 AM

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • Default disables the ContainerStats feature as it is no longer required.

Links to Issues or tickets this PR addresses or fixes

  • Partially fixes ENG-2887. An additional Frontend change is also required.

What risks are associated with merging this PR? What is required to fully test this PR?

TODO

How was this PR tested?

TODO

Have you made an update to documentation? If so, please provide the corresponding PR.

TODO

@chipzoller
Copy link
Collaborator

2.4?

@thomasvn
Copy link
Member Author

@chipzoller Not urgent, but 2.4 would be nice! It requires an associated Frontend change. https://kubecost.atlassian.net/browse/ENG-2887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants