Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing go-install-tool in the Makefile makes it easier to set up the development environment #2347

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

forsaken628
Copy link
Contributor

What this PR does / why we need it:
Current development environments use binary tools that are not isolated, which makes switching between projects troublesome and error-prone. We can improve this situation by introducing go-install-tool in the makefile.

alse see:
https://github.com/kubernetes-sigs/kubebuilder/blob/98d03bed2912b2f7adf73aeaf5f64fafa8fd927b/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go#L263-L275

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: forsaken628 <[email protected]>
Signed-off-by: forsaken628 <[email protected]>
Signed-off-by: forsaken628 <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Sep 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this Sep 28, 2024
@andreyvelich
Copy link
Member

@forsaken628 I apologies that we don't have time to review this improvement. Are we ready to review this PR ?
@Electronic-Waste @helenxie-bit @tenzen-y Please can you help with review of this PR ?

@tenzen-y
Copy link
Member

tenzen-y commented Oct 8, 2024

@forsaken628 I apologies that we don't have time to review this improvement. Are we ready to review this PR ? @Electronic-Waste @helenxie-bit @tenzen-y Please can you help with review of this PR ?

I don't think that we should take this approach. Instead of this, we should enforce the fixed version tools to $REPO_DIR/bin directory so that we can use the same version in our local.

Example: https://github.com/kubeflow/training-operator/blob/cbd4ae7bb32164816278fc0e313effc14b5d2161/Makefile#L119-L125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants