🌱 clusterctl: add nutanix ipam & runtime extensions providers #11135
Conversation
jimmidyson
commented
Sep 4, 2024
jimmidyson
commented
- 🌱 clusterctl: add nutanix ipam provider
- 🌱 clusterctl: add nutanix runtime extensions provider
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
jimmidyson
force-pushed
the
jimmi/add-caren-caipamx
branch
from
e0976e0
to
a74ed48
Compare
jimmidyson
force-pushed
the
jimmi/add-caren-caipamx
branch
from
a74ed48
to
aca26cf
Compare
|
/area clusterctl |
k8s-ci-robot
added
area/clusterctl
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
@elmiko @JoelSpeed if you have time for review 🙏 should be pretty quick and easy hopefully. |
| @@ -98,13 +98,19 @@ const ( | |||
| // IPAM providers. | |||
| const ( | |||
| InClusterIPAMProviderName = "in-cluster" | |||
| NutanixIPAMProviderName = "nutanix" | |||
There was a problem hiding this comment.
| NutanixIPAMProviderName = "nutanix" | |
| NutanixIPAMProviderName = "nutanix-cloud-native-nutanix" |
To follow the conventions at https://main.cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#adding-a-provider-to-clusterctl
There was a problem hiding this comment.
We already have an infra provider simply called nutanix at https://github.com/kubernetes-sigs/cluster-api/blob/main/cmd/clusterctl/client/config/providers_client.go#L55 and it would be great if we could use the same name for these other provider types for consistency 🙏
There was a problem hiding this comment.
Good point. Maybe it's fine if a GitHub org already "claimed" the name via another provider
There was a problem hiding this comment.
Would make sense. Fine for me if we have an agreement :-)
There was a problem hiding this comment.
@fabriziopandini @vincepri WDYT?
| ) | ||
|
|
||
| // Add-on providers. | ||
| const ( | ||
| HelmAddonProviderName = "helm" | ||
| ) | ||
|
|
||
| // Runtime extensions providers. | ||
| const ( | ||
| NutanixRuntimeExtensionsProviderName = "nutanix" |
There was a problem hiding this comment.
| NutanixRuntimeExtensionsProviderName = "nutanix" | |
| NutanixRuntimeExtensionsProviderName = "nutanix-cloud-native-nutanix" |
To follow the conventions at https://main.cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#adding-a-provider-to-clusterctl
| | CAIPAMX | cluster.x-k8s.io/provider=ipam-nutanix | | ||
| | CAREN | cluster.x-k8s.io/provider=runtime-extensions-nutanix | |
There was a problem hiding this comment.
I'm surprised in one that it uses X for the provider identifier and the other uses N, should these not be consistent?
There was a problem hiding this comment.
I'm from the UK where carex is a major brand of soap 🤣 but you're right it would make sense to rename it to be consistent. I'll get on to that when I get a chance.
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
