-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix update method #86
base: monorepo
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrei Kvapil <[email protected]>
Signed-off-by: Andrei Kvapil <[email protected]>
Signed-off-by: Andrei Kvapil <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kvaps The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ng-build cloudbuild: use --load flag to allow pushing images
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kvaps please consider adding the BucketAccess @ line:325.
https://github.com/kubernetes-sigs/container-object-storage-interface-provisioner-sidecar/pull/139/files#diff-2e118dbe2d0a1402d0c3effb7008d7bd48608e30ec7e2c87e6258fce68424a57R325
thanks
Imported from kubernetes-sigs/container-object-storage-interface-provisioner-sidecar#139
This PR addresses two cases:
Controller Restarts:
When the controller restarts, it does not handle deletions for removed objects.
Specifically, when an object with a deletion timestamp is passed into the Add() method, the deletion process was not handled correctly.
Recreation of Objects:
The recreation of objects is not functioning as expected. For example, when an object is created, deleted, and then created again.
In this scenario, the object may enter the Update method, where the creation process was not being handled properly.