Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate descheduler custom flag of http-enabled #1503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

deprecate descheduler custom flag of http-enabled #1503

wants to merge 1 commit into from

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Aug 28, 2024

Follow up to #1496 (comment)

cc: @jklaw90 and @ingvagabund

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from a7i. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2024
a7i
a7i commented Aug 28, 2024
View reviewed changes
docs/cli/descheduler.md
@@ -19,10 +19,10 @@ descheduler [flags]
--client-connection-kubeconfig string File path to kube configuration for interacting with kubernetes apiserver.
--client-connection-qps float32 QPS to use for interacting with kubernetes apiserver.
--descheduling-interval duration Time interval between two consecutive descheduler executions. Setting this value instructs the descheduler to run in a continuous loop at the interval specified.
--disable-http2-serving If true, HTTP2 serving will be disabled [default=false]
--disable-http2-serving If true, HTTP2 serving will be disabled [default=false] (default true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't love this part :/ [default=false] (default true)

Copy link
Contributor

@ingvagabund ingvagabund Aug 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, [default=false] is part of the usage string. The descheduler code could access the usage string and drop [default=false]. I.e. calling VisitAll and editing Flag.Usage field. Worth trying that.

@jklaw90
Copy link
Contributor

jklaw90 commented Aug 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@jklaw90 jklaw90 Awaiting requested review from jklaw90

@knelasevero knelasevero Awaiting requested review from knelasevero

Assignees

@jklaw90 jklaw90

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7i @k8s-ci-robot @jklaw90 @ingvagabund