Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request for kubectl-pvcmount #4056

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pull request for kubectl-pvcmount #4056

wants to merge 1 commit into from

Conversation

Stenstromen
Copy link

Pull request for kubectl-pvcmount

@ahmetb
Copy link
Member

ahmetb commented Sep 10, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 10, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Stenstromen
Once this PR has been reviewed and has the lgtm label, please assign ahmetb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/new-plugin cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Stenstromen!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 10, 2024
ahmetb
ahmetb reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. Some cosmetic comments.

plugins/pvcmount.yaml
name: pvcmount
spec:
version: "v1.0.0"
shortDescription: Go binary for mounting persistent volumes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody cares if it's a go binary :)

Lets explain the functionality here please, such as:

Mount PersistentVolumes to Pods for debugging

plugins/pvcmount.yaml
This is useful for debugging purposes or for copying data from a PVC to another location.
The pvc is mounted to /mnt in a pod with a busybox container.
Examples:
`$ kubectl pvcmount pvc -p pvc-name -n namespace-containing-pvc`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend not listing usage here.

Anyone curious will run -h/-help or check your readme. This thing here will only go out of date.

@ahmetb
Copy link
Member

ahmetb commented Oct 6, 2024

Ping, if you are still interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb left review comments

@chriskim06 chriskim06 Awaiting requested review from chriskim06

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stenstromen @ahmetb @k8s-ci-robot