Merge pull request #3894 from PG2000/patch-1

✨ chore: add ginkgolinter
kubernetes-sigs · May 24, 2024 · 6c08ed1 · 6c08ed1
2 parents 19bf0c7 + ec805f8
commit 6c08ed1
Show file tree

Hide file tree

Showing 14 changed files with 101 additions and 92 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -68,6 +68,7 @@ linters:
     - dupl
     - errcheck
     - exportloopref
+    - ginkgolinter
     - goconst
     - gocyclo
     - gofmt

diff --git a/docs/book/src/cronjob-tutorial/testdata/project/.golangci.yml b/docs/book/src/cronjob-tutorial/testdata/project/.golangci.yml
@@ -22,6 +22,7 @@ linters:
     - dupl
     - errcheck
     - exportloopref
+    - ginkgolinter
     - goconst
     - gocyclo
     - gofmt

diff --git a/docs/book/src/getting-started/testdata/project/.golangci.yml b/docs/book/src/getting-started/testdata/project/.golangci.yml
@@ -22,6 +22,7 @@ linters:
     - dupl
     - errcheck
     - exportloopref
+    - ginkgolinter
     - goconst
     - gocyclo
     - gofmt

diff --git a/pkg/cli/cli_test.go b/pkg/cli/cli_test.go
@@ -372,7 +372,7 @@ plugins:
 				c.projectVersion = projectVersion
 
 				Expect(c.resolvePlugins()).To(Succeed())
-				Expect(len(c.resolvedPlugins)).To(Equal(1))
+				Expect(c.resolvedPlugins).To(HaveLen(1))
 				Expect(plugin.KeyFor(c.resolvedPlugins[0])).To(Equal(qualified))
 			},
 			Entry("fully qualified plugin", "foo.example.com/v1", "foo.example.com/v1"),