Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping up kubernetes version to 1.31.2 #3113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bumping up kubernetes version to 1.31.2 #3113

wants to merge 1 commit into from
+679 −1,116

Conversation

nikhilbarge
Copy link
Contributor

@nikhilbarge nikhilbarge commented Nov 18, 2024 •
edited
Loading

What this PR does / why we need it:
Upgrade kubernetes version to 1.31.2. code and tests fix required for k8s upgrade

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Running Pipelines

Manual testing performed, attached logs below
manual_testing.log

Special notes for your reviewer:

Release note:

Upgrade kubernetes version to 1.31.2. code and tests fix required for k8s upgrade

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nikhilbarge
Once this PR has been reviewed and has the lgtm label, please assign chethanv28 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @nikhilbarge. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 18, 2024
@akankshapanse
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2024
@nikhilbarge nikhilbarge force-pushed the upgrade-k8s-1.32 branch 5 times, most recently from 4e2f8b0 to 37c6b09 Compare November 21, 2024 16:48
@nikhilbarge nikhilbarge changed the title WIP: Bumping up kubernetes version to 1.31.2 Bumping up kubernetes version to 1.31.2 Nov 21, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
xing-yang
xing-yang reviewed Nov 21, 2024
View reviewed changes
pkg/syncer/cnsoperator/controller/cnsfileaccessconfig/cnsfileaccessconfig_controller.go
err = c.Watch(source.Kind(
mgr.GetCache(),
&cnsfileaccessconfigv1alpha1.CnsFileAccessConfig{},
&handler.TypedEnqueueRequestForObject[*cnsfileaccessconfigv1alpha1.CnsFileAccessConfig]{},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a required change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this change was necessary to fix build failures

pkg/syncer/resize_reconciler.go
@@ -87,7 +87,7 @@ func newResizeReconciler(
supervisorNamespace string,
resyncPeriod time.Duration,
informerFactory informers.SharedInformerFactory,
pvcRateLimitter workqueue.RateLimiter,
pvcRateLimitter workqueue.TypedRateLimiter[any],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a required change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workqueue.RateLimiter is deprecated, faced issues in "make check" so needed to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@akankshapanse akankshapanse Awaiting requested review from akankshapanse

@divyenpatel divyenpatel Awaiting requested review from divyenpatel

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhilbarge @k8s-ci-robot @akankshapanse @xing-yang