Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kevin to wg-batch-leads #4924

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

kannon92
Copy link
Contributor

  • Issue link:
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2024
@kannon92
Copy link
Contributor Author

/cc @alculquicondor @johnbelamaric

@alculquicondor
Copy link
Member

Probably worth updating sigs.yaml in the same PR

@kannon92
Copy link
Contributor Author

Where is that file @alculquicondor?

I updated sigs.yaml in the community repo.

@alculquicondor
Copy link
Member

Oops, yeah I got confused

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2024
@alculquicondor
Copy link
Member

/assign @johnbelamaric

@alculquicondor
Copy link
Member

/assign @dims

John is on vacation :)

@dims
Copy link
Member

dims commented Oct 25, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit d4a4f40 into kubernetes:master Oct 25, 2024
3 of 4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants