Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed helper import from l4lb #2579

Closed
wants to merge 2 commits into from

Conversation

08volt
Copy link
Contributor

@08volt 08volt commented Jun 3, 2024

issue #1902

Removed helper dependencies from the cloud-provider

Originally posted by Antonio Ojea in #1896 (comment)

Removed helper import from:
l4lb
loadbalancers
healthchecksl4
neg/controller.go
utils/patch/patch.go

Replaced import with private functions

Signed-off-by: Enrico <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @08volt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2024
@08volt
Copy link
Contributor Author

08volt commented Jun 3, 2024

/assign Elina Akhmanova Cezary Zawadka

@sawsa307
Copy link
Contributor

sawsa307 commented Jun 3, 2024

@cezarygerard
Copy link
Contributor

please run

go mod tidy
go mod verify
go mod vendor

and see if this PR removes dependencies

@08volt
Copy link
Contributor Author

08volt commented Jun 19, 2024

please run

go mod tidy go mod verify go mod vendor

and see if this PR removes dependencies

Done, no dependences removed

@cezarygerard
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2024
pkg/l4lb/l4lbcommon.go Outdated Show resolved Hide resolved
@aojea
Copy link
Member

aojea commented Jun 27, 2024

please run
go mod tidy go mod verify go mod vendor
and see if this PR removes dependencies

Done, no dependences removed

o mod why k8s.io/cloud-provider
# k8s.io/cloud-provider
k8s.io/ingress-gce/cmd/glbc/app
k8s.io/cloud-provider
aojea@aojea:~/src/ingress-gce$ grep -r k8s.io/cloud-provider/ cmd/
aojea@aojea:~/src/ingress-gce$ grep -r k8s.io/cloud-provider cmd
cmd/glbc/app/clients.go:        cloudprovider "k8s.io/cloud-provider"
cmd/glbc/app/clients.go:        "k8s.io/cloud-provider-gcp/providers/gce"
cmd/glbc/main.go:       firewallcrclient "k8s.io/cloud-provider-gcp/crd/client/gcpfirewall/clientset/versioned"
cmd/glbc/main.go:       networkclient "k8s.io/cloud-provider-gcp/crd/client/network/clientset/versioned"
cmd/e2e-test/psc_test.go:       "k8s.io/cloud-provider-gcp/providers/gce"
cmd/e2e-test/upgrade/psc.go:    "k8s.io/cloud-provider-gcp/providers/gce"

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 08volt
Once this PR has been reviewed and has the lgtm label, please ask for approval from cezarygerard. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@08volt 08volt closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants