Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure NEG Readiness Reflector commits endpoints from non-default subnets. #2727

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Ensure NEG Readiness Reflector commits endpoints from non-default subnets. #2727

wants to merge 14 commits into from

Commits on Nov 14, 2024

  1. Update namer interface to include NonDefaultSubnetNEG

    @sawsa307
    sawsa307 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    460f7d6 View commit details
    Browse the repository at this point in the history

  2. Exclude NodeTopologyInformer from hasSynced. 

    * Remove NodeTopologyInformer from controller context hasSynced so it
  won't block controllers from starting up in case of the CRD or CR does
  not exist.
    @sawsa307
    sawsa307 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fd001e7 View commit details
    Browse the repository at this point in the history

  3. Add NodeTopologyInformer to zoneGetter.

    @sawsa307
    sawsa307 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    be3c372 View commit details
    Browse the repository at this point in the history

  4. Fall back to only include default if nodeTopology CR isn't ready.

    @sawsa307
    sawsa307 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6e42596 View commit details
    Browse the repository at this point in the history

  5. Create additional NEGs based on subnets in Node Topology CR. 

    * Query Node Topology CR for the current set of NEGs in the cluster.
* When ensureNetworkEndpointGroups(), ensure NEGs are properly
  provisioned in the non-default subnets as well.
    @sawsa307
    sawsa307 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    055d691 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Use correct namer based on the NEG type.

    @sawsa307
    sawsa307 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    927b120 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. fixup! Fall back to only include default if nodeTopology CR isn't ready.

    @sawsa307
    sawsa307 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2e9a180 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. fixup! Create additional NEGs based on subnets in Node Topology CR.

    @sawsa307
    sawsa307 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    037a763 View commit details
    Browse the repository at this point in the history

  2. fixup! Use correct namer based on the NEG type.

    @sawsa307
    sawsa307 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cd6e627 View commit details
    Browse the repository at this point in the history

  3. fixup! Use correct namer based on the NEG type.

    @sawsa307
    sawsa307 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7724945 View commit details
    Browse the repository at this point in the history

  4. fixup! Fall back to only include default if nodeTopology CR isn't ready.

    @sawsa307
    sawsa307 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    20d4578 View commit details
    Browse the repository at this point in the history

  5. Export NegMeta.

    @sawsa307
    sawsa307 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    07cb8c2 View commit details
    Browse the repository at this point in the history

  6. Update test cases for readiness reflector related to msc. 

    * Update endpointMaps in testReflector to be pollMap so it is consistent
  with the actual implementation.
* Update endpointGroupInfo to include subnet in its value.
    @sawsa307
    sawsa307 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7a865c7 View commit details
    Browse the repository at this point in the history

  7. Ensure NEG Readiness Reflector commits endpoints from non-default 

    subnets.
    @sawsa307
    sawsa307 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    890034f View commit details
    Browse the repository at this point in the history