Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILB mixed protocol backend #2733

Conversation

TortillaZHawaii
Copy link
Contributor

@TortillaZHawaii TortillaZHawaii commented Nov 7, 2024

This PR allows the controller to create and migrate to L3 controllers. backends.GetProtocol will default to L3 protocol unless, there is already an existing service and ports that match the backend. For example if we have a running TCP backend and only services defined in the spec are TCP, it won't change protocol. However if we try to change from TCP to UDP, or mixed we will get L3. Once we are in L3 I don't think there is any reason to go out of it. pkg/backends/protocol_test.go contains an exhaustive list of scenarios and expected behavior.

In draft until the L4 Mixed Protocol feature flag is merged.

Alternative that does not take into account existing services can be found here: #2739

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TortillaZHawaii
Once this PR has been reviewed and has the lgtm label, please assign kl52752 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @TortillaZHawaii. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2024
Also injects EnableL4MixedProtocol feature flag to L4 ILB.
@TortillaZHawaii TortillaZHawaii marked this pull request as ready for review November 8, 2024 11:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
@TortillaZHawaii
Copy link
Contributor Author

/assign @mmamczur

@mmamczur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2024
// Otherwise prefer L3.
//
// See https://cloud.google.com/load-balancing/docs/internal#forwarding-rule-protocols
func GetProtocol(svcPorts []api_v1.ServicePort, existingBS *composite.BackendService) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to not use L3 by default
if we have non-mixed proto service then stick to the old behavior
if there is a mixed proto service then use L3
if service was single protocol but becomes multi protocol lets recreate the backend service

We can consider doing L3 Backend Services by default but only if we get 100% confirmation from the LB teams that there would be no limitations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree.

I will mark it as in draft until we have confirmation.

@TortillaZHawaii
Copy link
Contributor Author

/hold

Waits for confirmation on feature differences between L3 and TCP/UDP backend services from L4 teams.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2024
@TortillaZHawaii TortillaZHawaii marked this pull request as draft November 15, 2024 12:28
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
@TortillaZHawaii
Copy link
Contributor Author

Alternative solution that does not change how we handle single protocol backend services: #2739

@TortillaZHawaii
Copy link
Contributor Author

Closed as we will pursue alternative solution #2739 that doesn't default to L3 Backend Service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants