kinder: switch all workflows to containerd #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch all e2e test workflows to use containerd as the CR for the time being. Dockershim is being removed from k/k and until cri-dockerd gains maintainer traction we should avoid setting up our selfs for the sake of testing Docker as the CR. Technically the dockershim removal only affects "latest" workflows but this change will apply it to all k/k branches. Once and if cri-dockerd is testable we can add a single workflow for Docker as the CR.
neolit123
added
priority/important-soon
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/cluster-lifecycle
hm...could be a flake calling --version in the etcd containers |
|
seems to not fail locally. |
|
+1 to this change |
|
/test pull-kubeadm-kinder-upgrade-latest |
|
not reproducible locally log: in the failure logs, etcd pods appear to be running after the upgrade, so this might be caused by some weird kubectl exec semantic vs container state on a slower system (i.e. CI is slower) after the upgrade in the workflow... it might be worth waiting in a loop for ~10 seconds for if that also doesn't work this has to be removed from cluster-info: kubeadm/kinder/pkg/cluster/manager/actions/cluster-info.go Lines 59 to 99 in ecb3d22 |
|
/retest |
During CI the cluster-info fails with 'etcd --version' exiting with status 1, but locally this cannot be reproduced. Retry the command 10 times to try to avoid flakes.
neolit123
force-pushed
the
1.24-switch-all-workflows-to-containerd
branch
from
b21774a
to
6fe0dde
Compare
|
i think this may have been a weird kubekins problem, because i saw some kubekins revert PRs in test-infra. regardless the cluster-info code now has retries: |
|
self-LGTM-ing since all docker jobs will start failing..... |
neolit123
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch all e2e test workflows to use containerd as the CR for the time
being. Dockershim is being removed from k/k and until cri-dockerd
gains maintainer traction we should avoid setting it up our selfs
for the sake of testing Docker as the CR.
Technically the dockershim removal only affects "latest" workflows
but this change will apply it to all k/k branches. Once and if
cri-dockerd is testable we can add a single workflow for Docker
as the CR.
xref #1412 (comment)