-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linux command in pushing.md to use docker daemon inside minikube #19552
base: master
Are you sure you want to change the base?
Conversation
Change in the command to use the docker daemon hosted on minikube
The committers listed above are authorized under a signed CLA. |
Welcome @amigueldiez! |
Hi @amigueldiez. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amigueldiez The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
|
Description of change
This update corrects a command in the documentation related to using the Docker daemon with Minikube. The previous command was invalid, and it has been replaced with the correct one that properly connects to Minikube's Docker daemon.
Details
By running the following command in the terminal:
The output is:
The command shown at the end
(eval $(minikube -p minikube docker-env))
is the one that works and should be used, whereas the one previously found in the documentation is incorrect. This update replaces the invalid command with the correct one.