Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt-qemu error message should mention $MINIKUBE_HOME #19557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libvirt-qemu error message should mention $MINIKUBE_HOME #19557

wants to merge 1 commit into from
+11 −11

Conversation

peterbecich
Copy link
Contributor

@peterbecich peterbecich commented Sep 2, 2024 •
edited
Loading

Error message was
"Ensure that the user listed in /etc/libvirt/qemu.conf has access to your home directory"

It is not always the home directory. I propose changing it to:
"Ensure that the user listed in /etc/libvirt/qemu.conf has access to your home directory or $MINIKUBE_HOME"

related issue: #5950

The translations will need to be fixed.

@peterbecich
libvirt-qemu error message should mention $MINIKUBE_HOME
42a80ed 
Error message was
"Ensure that the user listed in /etc/libvirt/qemu.conf has access to your home directory"

It is not always the home directory

related issue: kubernetes#5950

I have not translated this correctly.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: peterbecich
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @peterbecich. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh Awaiting requested review from medyagh

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterbecich @k8s-ci-robot @minikube-bot