Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run watchlist tests on public cluster #29531

Merged
merged 1 commit into from
May 17, 2023
Merged

Run watchlist tests on public cluster #29531

merged 1 commit into from
May 17, 2023

Conversation

Argh4k
Copy link
Contributor

@Argh4k Argh4k commented May 16, 2023

This is a temporary workaround around #29500

The proper solution is to fix scalability jobs private cluster setup, but it looks like a non-trivial task compared to this change.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels May 16, 2023
@k8s-ci-robot k8s-ci-robot added area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Argh4k. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2023
@Argh4k
Copy link
Contributor Author

Argh4k commented May 16, 2023

/assign p0lyn0mial

@p0lyn0mial
Copy link
Contributor

From what I understand the scalability test are run on a private cluster so that they don't consume public IPs. Since this test will allocate only 2 node I think we should be fine for now.

@p0lyn0mial
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2023
@p0lyn0mial
Copy link
Contributor

@mborsz mind approving this PR?

@mborsz
Copy link
Member

mborsz commented May 17, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Argh4k, mborsz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 979cf50 into kubernetes:master May 17, 2023
@k8s-ci-robot
Copy link
Contributor

@Argh4k: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-experimental-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml

In response to this:

This is a temporary workaround around #29500

The proper solution is to fix scalability jobs private cluster setup, but it looks like a non-trivial task compared to this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Contributor

@mborsz mind rerunning manually https://prow.k8s.io/?job=ci-kubernetes-e2e-gci-gce-scalability-watch-list-on and https://prow.k8s.io/?job=ci-kubernetes-e2e-gci-gce-scalability-watch-list-off ?

I don't have permissions, just want to make sure it works.

@mborsz
Copy link
Member

mborsz commented May 17, 2023

Triggered

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-scalability-watch-list-on/1658765713478782976

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-scalability-watch-list-off/1658765757233762304

@p0lyn0mial p0lyn0mial mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@mm4tt mm4tt Awaiting requested review from mm4tt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mborsz mborsz

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Argh4k @k8s-ci-robot @p0lyn0mial @mborsz