Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: Remove duplicated etcd robustness periodic job #33446

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 10, 2024

This pull request has two commits:

  1. Replace apt updates with apt-get -o APT::Update::Error-Mode=any update, which was initially worked on fix: Use apt -o APT::Update::Error-Mode=any for updating package lists #32602, reported on fatal error: fuse3/fuse.h: No such file or directory etcd-io/etcd#17870 and addressed in github workflow: fix all apt-install error return code etcd-io/etcd#17984. However, the PR from this repository didn't change all instances where apt update was called.
  2. Remove ci-etcd-robustness-{arm64,amd64} in favor of ci-etcd-robustness-main-{arm64,amd64}, as discussed in Migrate the robustness tests to prow etcd-io/etcd#18136.

Part of #32754 / kubernetes/k8s.io#6102

/cc @jmhbnz @serathius

This was initially done in kubernetes#32602, but this pull request didn't change
all of the places where robustness tests called apt-get update.
As discussed in etcd-io/etcd#18136, ci-etcd-robustness-{arm64,amd64}
were a duplication of the main branch jobs.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs area/testgrid size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 10, 2024
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for tidying these up @ivanvc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9696171 into kubernetes:master Sep 10, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-periodics.yaml using file config/jobs/etcd/etcd-periodics.yaml

In response to this:

This pull request has two commits:

  1. Replace apt updates with apt-get -o APT::Update::Error-Mode=any update, which was initially worked on fix: Use apt -o APT::Update::Error-Mode=any for updating package lists #32602, reported on fatal error: fuse3/fuse.h: No such file or directory etcd-io/etcd#17870 and addressed in github workflow: fix all apt-install error return code etcd-io/etcd#17984. However, the PR from this repository didn't change all instances where apt update was called.
  2. Remove ci-etcd-robustness-{arm64,amd64} in favor of ci-etcd-robustness-main-{arm64,amd64}, as discussed in Migrate the robustness tests to prow etcd-io/etcd#18136.

Part of #32754 / kubernetes/k8s.io#6102

/cc @jmhbnz @serathius

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the remove-duplicated-etcd-robustness-periodic-job branch September 10, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants