-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: Remove duplicated etcd robustness periodic job #33446
etcd: Remove duplicated etcd robustness periodic job #33446
Conversation
This was initially done in kubernetes#32602, but this pull request didn't change all of the places where robustness tests called apt-get update.
As discussed in etcd-io/etcd#18136, ci-etcd-robustness-{arm64,amd64} were a duplication of the main branch jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for tidying these up @ivanvc
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ivanvc: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This pull request has two commits:
apt update
s withapt-get -o APT::Update::Error-Mode=any update
, which was initially worked on fix: Use apt -o APT::Update::Error-Mode=any for updating package lists #32602, reported on fatal error: fuse3/fuse.h: No such file or directory etcd-io/etcd#17870 and addressed in github workflow: fix all apt-install error return code etcd-io/etcd#17984. However, the PR from this repository didn't change all instances whereapt update
was called.ci-etcd-robustness-{arm64,amd64}
in favor ofci-etcd-robustness-main-{arm64,amd64}
, as discussed in Migrate the robustness tests to prow etcd-io/etcd#18136.Part of #32754 / kubernetes/k8s.io#6102
/cc @jmhbnz @serathius