Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kettle image to match that in k8s.io deployment file. #33717

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

michelle192837
Copy link
Contributor

Similar to #33628, pretty sure no jobs care about this file but I'm updating it for consistency.

Ref: #33381

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kettle sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 23, 2024
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

TODO: maybe we should just point to the k8s.io deployment, I think we might be the only ones running kettle anywhere anyhow, it's not really fixed up to be generic currently and has some hard-coded kubernetes-isms (which also might need revisiting, like the log sanitation given we've had changes to k/k testing ........ @aojea @pohly something else for the backlog -- we have hard-coded regexes here to strip pointers, log timestamps and other per-run noise to improve failure message clustering)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f348603 into kubernetes:master Oct 24, 2024
5 checks passed
@pohly
Copy link
Contributor

pohly commented Oct 28, 2024

we have hard-coded regexes here to strip pointers, log timestamps and other per-run noise to improve failure message clustering

I think those should still work - or at least I don't remember anything which might break it. Of course, double-checking wouldn't hurt, if someone wants to look into this.

@BenTheElder
Copy link
Member

I think those should still work - or at least I don't remember anything which might break it. Of course, double-checking wouldn't hurt, if someone wants to look into this.

yeah, they mostly seem to work, but we haven't re-checked this assumption in nearly a decade and it's probably worth looking at sometime

@michelle192837 michelle192837 deleted the kettlefix branch November 9, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kettle cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants