-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move stable node feature specific jobs to release-blocking #33811
base: master
Are you sure you want to change the base?
Conversation
/assign @yujuhong |
These tests have been flaky for a long time. Even though they are green, why choose this over other green tests? I’d also like to see why the crio eviction jobs are still flaky. Containerd seems fine but crio still flakes on pid eviction. |
tests for features like eviction, cpu/memory/topology managers are quite stable. they should be considered release-blocking
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AnishShah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I intend to make the CPU, memory, and topology manager tests release-blocking again. These tests have been stable recently, so I believe it's appropriate to reinstate their blocking status. I'm not entirely sure why they were initially made non-blocking, but I suspect it was due to flakiness in the past. |
So SIG-Node-Release-Blocking is a bit of a misnomer. Release does not look at that board to determine if there is a problem for the release. They would look at their sig-release board and we have a different process to include that to consider them "release blocking". Serial tests are mostly used by us to determine issues. I'm happy to move these tests to release blocking but I wanted to clarify this. |
Sounds good. I was aware of this. What's the process to include these tests in sig-release dashboard? I can follow-up on this too |
After delaking eviction tests in kubernetes/kubernetes#127874 and kubernetes/kubernetes#126927, we have almost 2 weeks of green runs for eviction tests - https://testgrid.k8s.io/sig-node-containerd#node-kubelet-containerd-eviction.
We should make these jobs release-blocking since Eviction is a stable feature.
/sig node
/assign @SergeyKanzhelev