Bump Docsy to 0.7.x #48725
Open
Bump Docsy to 0.7.x #48725
+365
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/web-development
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
In the deploy preview (here), I noticed that the search query text in the navbar input box is currently invisible due to the text color being white.
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Ah, this needs a fix! |
sftim
force-pushed
the
20241102_docsy_zero_seven
branch
2 times, most recently
from
38c2fe6
to
2f60fd0
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chalin
reviewed
Nov 16, 2024
package.json
Outdated
Comment on lines
1
to
8
| { | ||
| "private": true, | ||
| "dependencies": { | ||
| "docsy": "github:google/docsy#v0.7.2" | ||
| }, | ||
| "devDependencies": { | ||
| "autoprefixer": "^9.8.4", | ||
| "postcss-cli": "^7.1.1" |
There was a problem hiding this comment.
All are devDependencies:
Suggested change
| { | |
| "private": true, | |
| "dependencies": { | |
| "docsy": "github:google/docsy#v0.7.2" | |
| }, | |
| "devDependencies": { | |
| "autoprefixer": "^9.8.4", | |
| "postcss-cli": "^7.1.1" | |
| { | |
| "private": true, | |
| "devDependencies": { | |
| "autoprefixer": "^9.8.4", | |
| "docsy": "google/docsy#semver:0.7.2", | |
| "postcss-cli": "^7.1.1" |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3dbdac5eb865ca0edc576155cff3809885318103
|
sftim
force-pushed
the
20241102_docsy_zero_seven
branch
from
2f60fd0
to
b6ea0af
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
added
size/XL
sftim
force-pushed
the
20241102_docsy_zero_seven
branch
from
b6ea0af
to
21a0c9b
Compare
k8s-ci-robot
added
the
needs-rebase
sftim
force-pushed
the
20241102_docsy_zero_seven
branch
from
21a0c9b
to
32d38fd
Compare
k8s-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to a newer version of Docsy: 0.7.2 (preview)
In the testing I've done, I haven't found any different look or behavior that still needs fixing. The top nav doesn't look right, though.
/area web-development
This PR incorporates the commits from PRs: