Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add json output as otel assertions custom message #925

Merged

Conversation

fabriziosestito
Copy link
Contributor

Description

Sporadically, the test_otel integration test fails in the CI (see #916).
However, this proved to be hard to reproduce locally.
For this reason, we are adding the full output as a custom message to the failing assertion, so we can debug the flakiness in a later step.

@fabriziosestito fabriziosestito self-assigned this Sep 25, 2024
@fabriziosestito fabriziosestito changed the title Test/add output to otel assertions test: add json output as otel assertions custom message Sep 25, 2024
@fabriziosestito fabriziosestito marked this pull request as ready for review September 25, 2024 12:59
@fabriziosestito fabriziosestito requested a review from a team as a code owner September 25, 2024 12:59
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.11%. Comparing base (400ca81) to head (a11c721).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   63.11%   63.11%           
=======================================
  Files          17       17           
  Lines        1052     1052           
=======================================
  Hits          664      664           
  Misses        388      388           
Flag Coverage Δ
integration-tests 55.56% <ø> (ø)
unit-tests 38.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flavio flavio merged commit 2b57879 into kubewarden:main Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants