Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemini talk to images #439

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Raghavan1988
Copy link
Contributor

@Raghavan1988 Raghavan1988 commented Dec 24, 2023

Article on building an application that can talk to images in PDFs with Gemini Vision Pro

Leverage the power of Gemini Vision Pro and Spire to answer natural language questions based on images in PDF

@Raghavan1988
Copy link
Contributor Author

requesting review @ezzcodeezzlife @OlesiaZinchenko

@DonGuillotine DonGuillotine added REVISION Please review your PR again. Check for DEV comments to improve and removed REVISION Please review your PR again. Check for DEV comments to improve labels Jan 28, 2024
Copy link
Collaborator

@DonGuillotine DonGuillotine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Raghavan1988,

Great work on the tutorial, it's informative and engaging.

During my review, I identified a specific area that needs your attention:

  • Your tutorial currently uses more than three H2 headings. Please adjust the heading levels. Specifically, the sections "Step-by-Step Tutorial," "Demo screenshots," and "Conclusion" should use H2 headings instead of H3.

Thank you for your contribution to our community and for your attention to these details.

@Raghavan1988
Copy link
Contributor Author

@DonGuillotine Thanks for the valuable comments. I made changes in line with your recommendation.

@DonGuillotine
Copy link
Collaborator

@DonGuillotine Thanks for the valuable comments. I made changes in line with your recommendation.

Hello @Raghavan1988,

Thank you so much for updating the tutorial,

I've noticed that some of the code snippets provided are incomplete, containing placeholders like # PDF processing code here.... Readers may not understand exactly what steps are required to process the PDFs, especially if they are beginners.

Kindly complete the Code Snippets, wherever placeholders are used provide the actual code that accomplishes the task described.

Also I noticed that in the working code you provided (your GitHub repository) you made use of trulens, consider adding a section in the tutorial that briefly introduces trulens and it's capabilities this will help the reader with more context.

Your tutorial is a valuable resource and these updates would greatly benefit the community. Great work so far 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants