Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users with debug enabled that middleware errors are not handled #2374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Warn users with debug enabled that middleware errors are not handled #2374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7e0f16
log warn message
Dec 30, 2022
8f8b47e
Merge branch 'labstack:master' into fb-logResponseCommitted
apatruni Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions echo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,9 @@ func (e *Echo) Routers() map[string]*Router {
func (e *Echo) DefaultHTTPErrorHandler(err error, c Context) {

if c.Response().Committed {
if e.Debug {
e.Logger.Debug("Response is already committed, returning immediately")
}
return
}

Expand Down