Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Use Torchlight code fence filename attribute #9972

Draft
wants to merge 2 commits into
base: 11.x
Choose a base branch
from

Conversation

shaedrich
Copy link
Contributor

@shaedrich shaedrich commented Oct 20, 2024

Use Torchlight code fence filename attribute

Before After
grafik grafik

Should the filenames start with a /?

@taylorotwell
Copy link
Member

Looks like this on my machine

CleanShot 2024-10-21 at 14 45 13@2x

@taylorotwell taylorotwell marked this pull request as draft October 21, 2024 19:45
@shaedrich
Copy link
Contributor Author

Yeah, I also noticed that there's some stuff missing. Weird package 🤔 @nunomaduro also had to add some CSS when he did laravel/laravel.com#318

@shaedrich
Copy link
Contributor Author

@taylorotwell Do I take it that it's worth putting effort into that?

@shaedrich
Copy link
Contributor Author

I added the missing CSS via laravel/laravel.com#366, so this PR can be merged as soon as the other one at laravel/laravel.com is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants