Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Introduce throw() to PendingDispatch #52394

Draft
wants to merge 15 commits into
base: 11.x
Choose a base branch
from
Draft

[11.x] Introduce throw() to PendingDispatch #52394

wants to merge 15 commits into from

Commits on Aug 6, 2024

  1. execute callback before throwing exception

    @tiramisuliu
    tiramisuliu committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8e96626 View commit details
    Browse the repository at this point in the history

  2. bug-fix: ensure JobDispatchedException is not thrown if there's no th… 

    …row callback
    @tiramisuliu
    tiramisuliu committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e0727c1 View commit details
    Browse the repository at this point in the history

  3. style: correct comments

    @tiramisuliu
    tiramisuliu committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ca78e0a View commit details
    Browse the repository at this point in the history

  4. add UniqueJobDispatchingTest

    @tiramisuliu
    tiramisuliu committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ce66665 View commit details
    Browse the repository at this point in the history

  5. apply StyleCI suggestions

    @tiramisuliu
    tiramisuliu committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4780bd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. use default test settings from the parent class

    @tiramisuliu
    tiramisuliu authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    c970ed4 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. move ThrowableUniqueJob to Fixtures\UniqueJob

    @tiramisuliu
    tiramisuliu committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    46706be View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. remove UniqueJobDispatchingTest and Fixtures/UniqueJob

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    101844e View commit details
    Browse the repository at this point in the history

  2. add Fixtures/UniqueJob

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    be6bea4 View commit details
    Browse the repository at this point in the history

  3. only testSubsequentUniqueJobDispatchAreIgnored

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    5356680 View commit details
    Browse the repository at this point in the history

  4. add testSubsequentUniqueJobDispatchCanThrowWithCallback

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d3ac032 View commit details
    Browse the repository at this point in the history

  5. add all tests back and update application logic

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d322abc View commit details
    Browse the repository at this point in the history

  6. always set the throwCallback property if the throw() method is called

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ddc4a3d View commit details
    Browse the repository at this point in the history

  7. update test to testFirstUniqueJobDispatchDoesNotThrow

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9204701 View commit details
    Browse the repository at this point in the history

  8. change is_null to !is_callable

    @tiramisuliu
    tiramisuliu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2b362e4 View commit details
    Browse the repository at this point in the history