Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for go-keyring bug on linux distros #282

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

lemoony
Copy link
Owner

@lemoony lemoony commented Nov 14, 2024

Temporary workaround for #268

@lemoony lemoony added bug Something isn't working and removed bug Something isn't working labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (15e6e25) to head (78d96ef).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/cache/secrets.go 75.00% 4 Missing and 3 partials ⚠️
internal/app/app.go 42.85% 3 Missing and 1 partial ⚠️
internal/cache/cache.go 66.66% 1 Missing and 1 partial ⚠️
internal/managers/provider.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   78.98%   78.96%   -0.02%     
==========================================
  Files         128      128              
  Lines        7046     7074      +28     
==========================================
+ Hits         5565     5586      +21     
- Misses       1206     1210       +4     
- Partials      275      278       +3     
Flag Coverage Δ
Linux 78.76% <58.33%> (-0.06%) ⬇️
macOS 78.93% <70.83%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lemoony lemoony merged commit 649f7b5 into main Nov 14, 2024
5 of 7 checks passed
@lemoony lemoony deleted the features/secrets-storage-config branch November 14, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant