Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: aria-current end-to-end tests (#3213) #3249

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

metatoaster
Copy link
Contributor

@metatoaster metatoaster commented Nov 17, 2024

End-to-end tests for #3213.

Edit: Not sure why the autofix.ci decided to kick in here but that CI setup probably should be done with the original pull request that introduce this to have a clean slate for this pull request to apply to.

@benwis
Copy link
Contributor

benwis commented Nov 17, 2024

@metatoaster It ran because it found a redundant match in your PR, I believe it runs cargo clippy on PRs now and fixes it when it can

@gbj
Copy link
Collaborator

gbj commented Nov 17, 2024

The redundant match is in code other than this PR, so I'm not sure why it wasn't caught at some other point, but the other CI did pass on the PR and on the version with the fix. I will merge them as separate commits.

@gbj
Copy link
Collaborator

gbj commented Nov 17, 2024

(Oh and thanks very much for adding the tests!)

@gbj gbj merged commit 36132a5 into leptos-rs:main Nov 17, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants