use equals instead of == #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this needs changing on line 149 as well. And a +1 for this pull request - I was about to make the same request, so you saved me some time :) |
|
Hi! I've just opened another pull request on that issue: #105 My solution is a little bit more general and maintains backward compatibility with older versions of the library, where identity check was used. Please, check it too. |
tommyettinger
added a commit
that referenced
this pull request
Nov 25, 2021
You can use an EqualsMethodStopCondition to compare easily with .equals(), or implement StopCondition however you want.
|
This is effectively possible now via a StopCondition added by #105 . There's a EqualsMethodStopCondition available by default now, which should act like this PR does. Thanks for waiting this out so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across the issue described in #67 and thought you might consider it more if I went ahead and put up a PR :D