New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: Blob type for oid field and libgit2 allocation #20

Open

gumenikav wants to merge 1 commit into libgit2:master from gumenikav:sqlite_key_and_alloc_fix

gumenikav commented Mar 6, 2017

Text field is not suitable for an oid data, because of an oid can contain null-symbols.
The buffer should be allocated using the function git_odb_backend_malloc to ensure that it can be safely freed later
Тhere is no need to copy data(SQLITE_TRANSIENT) since query to the database is done in the scope of the same function


          * Primary key(git oid) is now blob field

fcf999c

* Memory allocation using git_odb_backend_malloc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet