Update libgit2 to v1.1.1 #114
Conversation
There was a problem hiding this comment.
There seem to be some changes in the API in the recent versions of libgit2, so some more work is required. Please have a look at: mendix/libgit2sharp@f958478
We've forked the project to incorporate some changes we need. Unfortunately, we could not get much attention for our pull requests in this repository, and we kept accidentally creating new pull requests to this upstream repo, so we had to disconnect our fork from it.
|
Thanks for the info @A-Ovchinnikov-mx ! It's too bad we can't all work on the upstream repository 😭 |
|
You can. LibGit2Sharp needs a maintainer. Maybe that person is you!? libgit2/libgit2sharp#1834 |
|
I would love to help but I'm a bit afraid I won't be able to dedicate too much time to it 😬 And that would be my personal investment, not from the company. If that's already good enough, then I can drop a message in that thread from my personal GitHub account. |
jairbubbles
force-pushed
the
update-libgit2-to-v1-1-0
branch
from
567e1d9
to
3accd98
Compare
|
Hello @bording, I saw you did some modification recently and I was wondering what do you think of moving forward with the libgit version? A new version 1.1.1 was also published that we could target. I looked at @A-Ovchinnikov-mx commits but the fixes need to be done on libgit2sharp side. (It's linked to libgit2/libgit2#5117) |
My plan is to move up to a newer version of libgit2, but I was hoping to wait for libgit2/libgit2#5974 land first. |
|
I'm not particularly in a hurry so that's fine with me to wait for a newer version. In the meantime, would it be possible to publish an alpha version of the native binaries NuGet packages so that I can create a draft PR on libgit2sharp repo to make sure the CI is all green? |
jairbubbles
force-pushed
the
update-libgit2-to-v1-1-0
branch
from
3a088dd
to
989f084
Compare
I'm trying to update libgit2 to a more recent version to get support for the sparse checkout (see libgit2/libgit2sharp#1845)