Remove the optional parameters

libgit2 · Dec 2, 2021 · ee97bbf · ee97bbf
1 parent a8b1d51
commit ee97bbf
Showing 1 changed file with 28 additions and 5 deletions.
diff --git a/LibGit2Sharp/Repository.cs b/LibGit2Sharp/Repository.cs
@@ -482,7 +482,30 @@ private void Dispose(bool disposing)
         /// <returns>The path to the created repository.</returns>
         public static string Init(string path)
         {
-            return Init(path, false);
+            return Init(path, false, new InitOptions());
+        }
+
+        /// <summary>
+        /// Initialize a repository at the specified <paramref name="path"/>.
+        /// </summary>
+        /// <param name="path">The path to the working folder when initializing a standard ".git" repository. Otherwise, when initializing a bare repository, the path to the expected location of this later.</param>
+        /// <param name="isBare">true to initialize a bare repository. False otherwise, to initialize a standard ".git" repository.</param>
+        /// <returns>The path to the created repository.</returns>
+        public static string Init(string path, bool isBare)
+        {
+            return Init(path, isBare, new InitOptions());
+        }
+
+
+        /// <summary>
+        /// Initialize a repository by explictly setting the path to both the working directory and the git directory.
+        /// </summary>
+        /// <param name="workingDirectoryPath">The path to the working directory.</param>
+        /// <param name="gitDirectoryPath">The path to the git repository to be created.</param>
+        /// <returns>The path to the created repository.</returns>
+        public static string Init(string workingDirectoryPath, string gitDirectoryPath)
+        {
+            return Init(workingDirectoryPath, gitDirectoryPath, new InitOptions());
         }
 
         /// <summary>
@@ -492,11 +515,11 @@ public static string Init(string path)
         /// <param name="isBare">true to initialize a bare repository. False otherwise, to initialize a standard ".git" repository.</param>
         /// <param name="options">Additional optional parameters to be passed to the Init invocation</param>
         /// <returns>The path to the created repository.</returns>
-        public static string Init(string path, bool isBare, InitOptions options = null)
+        public static string Init(string path, bool isBare, InitOptions options)
         {
             Ensure.ArgumentNotNullOrEmptyString(path, "path");
 
-            using (RepositoryHandle repo = Proxy.git_repository_init_ext(null, path, isBare, options?.InitialHead))
+            using (RepositoryHandle repo = Proxy.git_repository_init_ext(null, path, isBare, options.InitialHead))
             {
                 FilePath repoPath = Proxy.git_repository_path(repo);
                 return repoPath.Native;
@@ -510,7 +533,7 @@ public static string Init(string path, bool isBare, InitOptions options = null)
         /// <param name="gitDirectoryPath">The path to the git repository to be created.</param>
         /// <param name="options">Additional optional parameters to be passed to the Init invocation</param>
         /// <returns>The path to the created repository.</returns>
-        public static string Init(string workingDirectoryPath, string gitDirectoryPath, InitOptions options = null)
+        public static string Init(string workingDirectoryPath, string gitDirectoryPath, InitOptions options)
         {
             Ensure.ArgumentNotNullOrEmptyString(workingDirectoryPath, "workingDirectoryPath");
             Ensure.ArgumentNotNullOrEmptyString(gitDirectoryPath, "gitDirectoryPath");
@@ -522,7 +545,7 @@ public static string Init(string workingDirectoryPath, string gitDirectoryPath,
 
             // TODO: Shouldn't we ensure that the working folder isn't under the gitDir?
 
-            using (RepositoryHandle repo = Proxy.git_repository_init_ext(wd, gitDirectoryPath, false, options?.InitialHead))
+            using (RepositoryHandle repo = Proxy.git_repository_init_ext(wd, gitDirectoryPath, false, options.InitialHead))
             {
                 FilePath repoPath = Proxy.git_repository_path(repo);
                 return repoPath.Native;