revert: removes date from & symlink to log files #394
Conversation
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
57a04f1
to
ee51f47
Compare
) This commit reverts the changes introduce by PR lightningdevkit#116 which added the date to log files when the node is started & a symlink to track the latest log file. This reversal is necessary to simplify the work required to integrate with OS-level log tools.
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
ee51f47
to
24cf565
Compare
| @@ -1231,6 +1231,8 @@ fn build_with_store_internal( | |||
| }) | |||
| } | |||
|
|
|||
| /// Sets up the node logger, creating a new log file if it does not exist, or utilizing | |||
| /// the existing log file. | |||
| fn setup_logger(config: &Config) -> Result<Arc<FilesystemLogger>, BuildError> { | |||
| let log_dir = match &config.log_dir_path { | |||
| Some(log_dir) => String::from(log_dir), | |||
There was a problem hiding this comment.
Github won't comment on the line below this, but let's drop the {storage_path_dir}/logs folder now that we'll only have one log file. Rather, let's just default to {storage_path_dir}/ldk_node.log.
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
109ab9c
to
c030775
Compare
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
c030775
to
dc9f840
Compare
| @@ -232,8 +232,8 @@ fn start_stop_reinit() { | |||
| node.sync_wallets().unwrap(); | |||
| assert_eq!(node.list_balances().spendable_onchain_balance_sats, expected_amount.to_sat()); | |||
|
|
|||
| let log_file_symlink = format!("{}/logs/ldk_node_latest.log", config.clone().storage_dir_path); | |||
| assert!(std::path::Path::new(&log_file_symlink).is_symlink()); | |||
| let log_file = format!("{}/ldk_node.log", config.clone().storage_dir_path); | |||
There was a problem hiding this comment.
Hmm, I wonder if now that we're only gonna have one file, we maybe should replace Config::log_dir_path with log_file_path, i.e., let users specify the full file name? Up to you, could also leave as is.
Note that if we change this in Config it might be a temporary solution only, as we should move log-related configuration options out of Config going forward when we allow to configure custom loggers.
There was a problem hiding this comment.
I think changing to log_file_path is clearer. I'll make the change now and can look at moving the log-related config when we are ready.
What this PR does:
Reverts the changes introduce by #116 which added the dates to log files whenever the node is started & a symlink to track the latest log file. This reversal is necessary to simplify the work required to integrate with OS-level log tools.
Related Issue
loggerinterface #309