[Splicing] Clone for ChannelContext #3332
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: This assumes that the whole
ChannelContext
is duplicated, which may not be the case in the final solution.Cloning of a channel -- more precisely of
ChannelContext
-- is needed for Splicing as well as for dual funding RBF, this is a preparation.Simple
#[derive(Clone))
is not sufficient, as the channel signer struct cannot be cloned, ultimately due toAtomicUSize
andSecp256k1
(inKeysManager
). So instead, a field-by-field cloning is done, with the a few exceptions.