Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ingress optional and ingressClass configurable #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p4block
Copy link

@p4block p4block commented Mar 12, 2024

A bigger rework of the chart comes to my mind but this suffices for my usecase.
Should be compatible with previous installs with no intervention.

Commenting on related things, fully decoupling the helmchart from gke/aws/do would be optimal, as there's really nothing that actually ties LiveKit to them. Ingress should also be decoupled from the loadbalancer, as TLS-terminating LBs can avoid the need for one if the user configured them but other people may use service+ingress instead.

Bringing up the chart to ie. Bitnami standard to allow fully changing every parameter would be a lot of work but ultimately desirable. I totally understand this may be out of scope for the chart and "users bring their your own yaml" may be preferred.

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Pablo Moyano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@wrenix
Copy link

wrenix commented Mar 27, 2024

the ingress is optional with loadBalancer.type="disable" ...

PS: i really dislike that schema loadBalancer instatt of ingress and type: disabled instatt of enabled: true/false. but maybe we should not create two schema for the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants