Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device id option for TF backend of DNN filter #16

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Device id option for TF backend of DNN filter #16

merged 2 commits into from
Sep 27, 2021

Conversation

cyberj0g
Copy link

jailuthra
jailuthra approved these changes Sep 24, 2021
View reviewed changes
Copy link

@jailuthra jailuthra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except some formatting/cleanup changes.

We should squash & merge this, changing the final commit name to something that follows the repository convention - like avfilter/dnn: add device_id option in TF backend

Once this PR is merged, let's update the install_ffmpeg.sh scripts in livepeer/lpms#264 and livepeer/go-livepeer#2038 with the new commit ID.

libavfilter/vf_livepeer_dnn.c Outdated Show resolved Hide resolved
libavfilter/dnn_filter_common.h Outdated Show resolved Hide resolved
libavfilter/vf_dnn_processing.c Outdated Show resolved Hide resolved
@cyberj0g cyberj0g merged commit b2728b4 into livepeer Sep 27, 2021
@yondonfu yondonfu mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jailuthra jailuthra jailuthra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyberj0g @jailuthra