refactor(runner): add InferenceError to all pipelines #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the inference error logic from the SAM2 pipeline to all pipelines so users are given a warning when they supply wrong arguments.
rickstaa
force-pushed
the
add_all_pipelines_inference_error
branch
from
f08aced
to
a469892
Compare
This commit ensures that users get a descriptive error message when the GPU runs out of memory.
This commit ensures that all response errors are known by FastAPI and therefore shown in the docs.
This commit adds some missing error handling to the pipeline worker functions.
rickstaa
commented
Sep 22, 2024
| error_message = "Out of memory error." | ||
| elif isinstance(e, InferenceError): | ||
| status_code = status.HTTP_400_BAD_REQUEST | ||
| error_message = str(e) |
There was a problem hiding this comment.
Check if errors are forwarded to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the inference error logic from the SAM2 pipeline to all pipelines so users are given a warning when they supply wrong arguments.