-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ai): add pipelines optimization flags #3013
Conversation
This commit adds a new `OptimizationFlags` field to the `aiModels` config so that users can forward optimization environment variables to the [ai-worker]([email protected]:livepeer/ai-worker.git) for more information see livepeer/ai-worker#61.
@yondonfu, is there a specific reason why the binary execution proceeds even when an AIModelConfig is not specified? I encountered this issue while trying to activate flags for containers that don't start warm, as I wanted to pass Optimization flags directly to the AIWorker constructor. go-livepeer/cmd/livepeer/starter/starter.go Lines 534 to 605 in 1019d42
|
Requires livepeer/ai-worker#61. |
I think it would sense to require a config file for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting for the thread that this will need a go mod update to use the latest version of ai-worker
once it is merged.
This commit ensures that the https://github.com/livepeer/ai-worker dependency is on the latest commit that includes the new optimization flags feature (see livepeer/ai-worker#61).
Ah thanks for the explanation. Makes sense. I will change the behavoir! |
This commit ensures that the `optimzation flag not supported` warning is shown for each model that is not loaded warm.
This commit adds a new section explaining the new `optimization_flags` that were enabled #3013.
This commit adds a new section explaining the new `optimization_flags` that were enabled #3013.
This commit adds a new section explaining the new `optimization_flags` that were enabled #3013.
This commit adds a new section explaining the new `optimization_flags` that were enabled #3013.
Warning
Do not merge before livepeer/ai-worker#61.
What does this pull request do? Explain your changes. (required)
This commit adds a new
OptimizationFlags
field to theaiModels
config so that users can forward optimization environment variables to the ai-worker for more information see livepeer/ai-worker#61.Specific updates (required)
OptimizationFlags
field added toaiModels
config.optimizationFlags
with non warm containers.How did you test each of these updates (required)
SFAST
optimization flag in the models configuration file.Does this pull request close any open issues?
No.
Checklist:
make
runs successfully./test.sh
pass - @rickstaa we still need to fix the tests.