-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for model folder on startup #3105
Conversation
@eliteprox do you think we could move the model exists check to the CheckAICapacity call? I think a log in that function call that the model folder does not exist would help the Orchestrator see whats going wrong and equally return a fast no capacity error so the Gateway can move on. We would then not need to export it and not include in the interface. Since they both return the same error thinking this is a little cleaner to just handle it in the ai-worker. WDYT? |
c7d1d66
to
04b4eb7
Compare
I've made that change and retested it successfully. It is now working with cold models also. Thanks for the recommendation!
This will just be a change to the ai-worker only now, so I'll close this PR |
Closing as the change will only require update to ai-runner and go mod can be updated in a release |
What does this pull request do? Explain your changes. (required)
This quality of life improvement helps validate the ai-worker can find the model folder on startup. It helps validate both the configuration and the docker-in-docker volume mapping which will greatly improve orchestrator experience. Without this change, the ai worker will timeout waiting for the container to become available.
This PR requires livepeer/ai-worker#131
Specific updates (required)
ModelExists
in ai-worker that returns boolean if specific model folder existsAI worker error log on startup:
Gateway error log:
AI Core error log on cold model request:
How did you test each of these updates (required)
aiModels.json
config containing a model that does not exist with warm set totrue
aiModels.json
config containing a model that does not exist with warm set tofalse
Does this pull request close any open issues?
Addresses LIV-117
Checklist:
make
runs successfully./test.sh
pass