workflows: Update build workflow to not rely on curl based upload #3117
Conversation
hjpotter92
force-pushed
the
hjp/build-workflow
branch
from
7858ec9
to
817c1c2
Compare
hjpotter92
force-pushed
the
hjp/build-workflow
branch
from
e8403b6
to
f14a8fb
Compare
hjpotter92
force-pushed
the
hjp/build-workflow
branch
from
5808819
to
8a7fe88
Compare
.github/discord-embed-webhook.py
Outdated
| embed.set_timestamp() | ||
| webhook.add_embed(embed) | ||
| response = webhook.execute() | ||
| print(response) |
There was a problem hiding this comment.
Should we check the response status and assert if it's 2XX? just printing errors won't fail the gihtub workflow
There was a problem hiding this comment.
This is sth new? Unrelated to the upload issue?
There was a problem hiding this comment.
the upload issue is because gcp deprecated its signature mechanism we were relying on in upload_build.sh script. it was also sending out separate build messages for each build to the discord channel instead of grouping them together.
| with: | ||
| path: ${{ steps.branch-manifest.outputs.manifest-file }} | ||
| destination: "build.livepeer.live/${{ github.event.repository.name }}/" | ||
| parent: false | ||
| process_gcloudignore: false | ||
|
|
||
| - name: Trigger discord webhook |
There was a problem hiding this comment.
Which Discord channel receives those messages? A comment in code would be nice
It would be better to have the description directly in the ticket, there is a template for that. Discord is not easily accessible and the conversation is behind a private channel, but this is an open source repo. |
| @@ -120,7 +111,6 @@ jobs: | |||
| run: go mod download | |||
|
|
|||
| - name: Install ffmpeg | |||
| if: steps.cache-ffmpeg.outputs.cache-hit != 'true' | |||
There was a problem hiding this comment.
curious why this is being removed since ffmpeg takes a long time to build
also seems unrelated to the rest of the PR
There was a problem hiding this comment.
the cache has not been working forever (screenshot below)
i tried fixing it in 3f048d0 (#3117) but that led to the next builds failing to find protoc. no idea why skipping ffmpeg install step leads to failure to find protoc (and we've observed this happen in the past too). would appreciate some insight into fixing the ffmpeg installation script if we can make use of caching there.
There was a problem hiding this comment.
Thanks for the context - I am not too familiar with the CI build actions myself. The only thing I can think of is there is a v4 update to the action
skipping ffmpeg install step leads to failure to find protoc
weird, maybe it implicitly installs protoc somehow ... but I am not seeing anything obvious in the install script (and my own box doesn't even have it)
updated the PR description. it doesnt follow the template structure, but did list out most of the changes covered. |
livepeer/organisationupload_build.shscript with python equivalent to only handle discord notification, uploads would be done as github actionscreenshot of difference between successful build notifications on discord (channel:
#builds):before:
after: