Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node version and orch addr to transcoded metadata #3165

Merged
merged 6 commits into from
Sep 9, 2024

Merge branch 'master' into ja/add-metadata

bff415c
Select commit
Loading
Failed to load commit list.
Merged

Add node version and orch addr to transcoded metadata #3165

Merge branch 'master' into ja/add-metadata
bff415c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 9, 2024 in 1s

57.38905% (+0.02133%) compared to a99a631

View this Pull Request on Codecov

57.38905% (+0.02133%) compared to a99a631

Details

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.38905%. Comparing base (a99a631) to head (bff415c).

Files with missing lines Patch % Lines
core/orchestrator.go 37.50000% 2 Missing and 3 partials ⚠️
core/transcoder.go 81.81818% 2 Missing ⚠️
cmd/livepeer/starter/starter.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3165         +/-   ##
===================================================
+ Coverage   57.36772%   57.38905%   +0.02133%     
===================================================
  Files             92          92                 
  Lines          15819       15841         +22     
===================================================
+ Hits            9075        9091         +16     
- Misses          6139        6142          +3     
- Partials         605         608          +3     
Files with missing lines Coverage Δ
core/livepeernode.go 68.18182% <ø> (ø)
core/streamdata.go 64.19753% <100.00000%> (+2.35542%) ⬆️
server/ot_rpc.go 36.13139% <100.00000%> (+0.23395%) ⬆️
cmd/livepeer/starter/starter.go 7.73694% <0.00000%> (-0.00749%) ⬇️
core/transcoder.go 43.30709% <81.81818%> (+1.60669%) ⬆️
core/orchestrator.go 77.77778% <37.50000%> (-0.54155%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99a631...bff415c. Read the comment docs.

Files with missing lines Coverage Δ
core/livepeernode.go 68.18182% <ø> (ø)
core/streamdata.go 64.19753% <100.00000%> (+2.35542%) ⬆️
server/ot_rpc.go 36.13139% <100.00000%> (+0.23395%) ⬆️
cmd/livepeer/starter/starter.go 7.73694% <0.00000%> (-0.00749%) ⬇️
core/transcoder.go 43.30709% <81.81818%> (+1.60669%) ⬆️
core/orchestrator.go 77.77778% <37.50000%> (-0.54155%) ⬇️