Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Fix usages of api.AssetSpec.Storage field, now a ptr #238

Merged
merged 1 commit into from
May 23, 2024

Conversation

victorges
Copy link
Member

Sometimes I hate go verbosity

@victorges victorges requested a review from a team as a code owner May 23, 2024 11:46
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 16.51270%. Comparing base (3d2a29a) to head (7cef519).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #238         +/-   ##
===================================================
- Coverage   16.56051%   16.51270%   -0.04781%     
===================================================
  Files             16          16                 
  Lines           1727        1732          +5     
===================================================
  Hits             286         286                 
- Misses          1416        1421          +5     
  Partials          25          25                 
Files Coverage Δ
task/runner.go 18.23899% <0.00000%> (-0.03832%) ⬇️
task/upload.go 15.82734% <0.00000%> (-0.11469%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2a29a...7cef519. Read the comment docs.

Files Coverage Δ
task/runner.go 18.23899% <0.00000%> (-0.03832%) ⬇️
task/upload.go 15.82734% <0.00000%> (-0.11469%) ⬇️

@victorges victorges merged commit e15ba37 into main May 23, 2024
13 checks passed
@victorges victorges deleted the vg/fix/storage-ref-usage branch May 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants