Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload: add static mp4 check #244

Merged
merged 1 commit into from
Jul 23, 2024
Merged

upload: add static mp4 check #244

merged 1 commit into from
Jul 23, 2024

Conversation

gioelecerati
Copy link
Member

@gioelecerati gioelecerati commented Jul 23, 2024

  • Add staticMp4 check to create mp4s when specified even when longer than maxDuration

@gioelecerati gioelecerati requested a review from a team as a code owner July 23, 2024 15:30
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@e3c1aba). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main        #244   +/-   ##
==========================================
  Coverage        ?   16.45642%           
==========================================
  Files           ?          16           
  Lines           ?        1744           
  Branches        ?           0           
==========================================
  Hits            ?         287           
  Misses          ?        1431           
  Partials        ?          26           
Files Coverage Δ
task/upload.go 15.79892% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c1aba...8ec8fef. Read the comment docs.

Files Coverage Δ
task/upload.go 15.79892% <0.00000%> (ø)

@gioelecerati gioelecerati merged commit 0d35cba into main Jul 23, 2024
10 of 12 checks passed
@gioelecerati gioelecerati deleted the gio/mp4/static-mp4 branch July 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants